Fixes some 500 returned by querier when storage cancellation happens. #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
approved these changes
Feb 25, 2021
For unknown reasons, Cortex is transforming all errors to promql.ErrStorage on the storage layer. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
slim-bean
force-pushed
the
500-querier
branch
from
1d23a72
to
34f8252
Compare
Codecov Report
@@ Coverage Diff @@
## master #3344 +/- ##
==========================================
+ Coverage 62.88% 62.95% +0.06%
==========================================
Files 205 205
Lines 17423 17426 +3
==========================================
+ Hits 10956 10970 +14
+ Misses 5484 5475 -9
+ Partials 983 981 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unknown reasons, Cortex is transforming all errors to promql.ErrStorage
on the storage layer.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com